KrishVora01 commented on code in PR #16664:
URL: https://github.com/apache/kafka/pull/16664#discussion_r1689688606
##########
docker/version_keys.py:
##########
@@ -0,0 +1,5 @@
+version_keys = {
Review Comment:
I used a python file for 2 main reasons
1. Simple json file has the overhead of opening the JSON file and loading
its contents into a Python object, and use it further (boils down to the same
as using a python dict)
2. Secondly, if for unsupported versions, we might want to remove GPG_KEYS,
working with python dicts would be much simpler for any automation script we
add.
LMK if these sound valid justifications for using a python dict as a new
python file.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
