cadonna commented on code in PR #16675:
URL: https://github.com/apache/kafka/pull/16675#discussion_r1689355081
##########
streams/src/main/java/org/apache/kafka/streams/processor/internals/ProcessorNode.java:
##########
@@ -214,9 +214,18 @@ public void process(final Record<KIn, VIn> record) {
internalProcessorContext.currentNode().name(),
internalProcessorContext.taskId());
- final ProcessingExceptionHandler.ProcessingHandlerResponse
response = processingExceptionHandler
- .handle(errorHandlerContext, record, e);
-
+ final ProcessingExceptionHandler.ProcessingHandlerResponse
response;
+
+ try {
+ response = processingExceptionHandler
+ .handle(errorHandlerContext, record, e);
+ } catch (final Exception fatalUserException) {
+ log.error(
+ "Processing error callback failed after processing error
for record {}",
+ record,
Review Comment:
We should not log records for privacy reasons. The exception should be
enough.
##########
streams/src/main/java/org/apache/kafka/streams/processor/internals/ProcessorNode.java:
##########
@@ -214,9 +214,18 @@ public void process(final Record<KIn, VIn> record) {
internalProcessorContext.currentNode().name(),
internalProcessorContext.taskId());
- final ProcessingExceptionHandler.ProcessingHandlerResponse
response = processingExceptionHandler
- .handle(errorHandlerContext, record, e);
-
+ final ProcessingExceptionHandler.ProcessingHandlerResponse
response;
+
+ try {
+ response = processingExceptionHandler
+ .handle(errorHandlerContext, record, e);
Review Comment:
nit:
```suggestion
response =
processingExceptionHandler.handle(errorHandlerContext, record, e);
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
