AndrewJSchofield commented on code in PR #15020:
URL: https://github.com/apache/kafka/pull/15020#discussion_r1687640852
##########
clients/src/main/java/org/apache/kafka/clients/consumer/internals/FetchRequestManager.java:
##########
@@ -55,15 +55,22 @@ public class FetchRequestManager extends AbstractFetch
implements RequestManager
this.networkClientDelegate = networkClientDelegate;
}
+ /**
+ * Node's availability will be checked at a later stage, so we default to
return false.
+ * @param node {@link Node} to check for availability
+ * @return
+ */
@Override
protected boolean isUnavailable(Node node) {
Review Comment:
This does seem a bit like half a refactor. Would it be possible to remove
`isUnavailable` and `maybeThrowAuthFailure` entirely from `AbstractFetch`?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
