jsancio commented on code in PR #16637:
URL: https://github.com/apache/kafka/pull/16637#discussion_r1687121475
##########
raft/src/test/java/org/apache/kafka/raft/RaftClientTestContext.java:
##########
@@ -641,19 +641,43 @@ void assertSentDescribeQuorumResponse(
long highWatermark,
List<ReplicaState> voterStates,
List<ReplicaState> observerStates
+ ) {
+ short apiVersion = (short) (kip853Rpc ? 2 : 1);
+ assertSentDescribeQuorumResponse(leaderId, leaderEpoch, highWatermark,
voterStates, observerStates, apiVersion, Errors.NONE);
+ }
+
+ void assertSentDescribeQuorumResponse(
+ int leaderId,
+ int leaderEpoch,
+ long highWatermark,
+ List<ReplicaState> voterStates,
+ List<ReplicaState> observerStates,
+ short apiVersion,
Review Comment:
See my other comment but that is what `withKip853Rpc` is for. `false` uses
the old version of the RPCs. `true` uses the new version of the RPCs.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
