satishd commented on code in PR #13535: URL: https://github.com/apache/kafka/pull/13535#discussion_r1686334247
########## storage/src/main/java/org/apache/kafka/storage/internals/log/RemoteStorageThreadPool.java: ########## @@ -0,0 +1,73 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one or more + * contributor license agreements. See the NOTICE file distributed with + * this work for additional information regarding copyright ownership. + * The ASF licenses this file to You under the Apache License, Version 2.0 + * (the "License"); you may not use this file except in compliance with + * the License. You may obtain a copy of the License at + * + * http://www.apache.org/licenses/LICENSE-2.0 + * + * Unless required by applicable law or agreed to in writing, software + * distributed under the License is distributed on an "AS IS" BASIS, + * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. + * See the License for the specific language governing permissions and + * limitations under the License. + */ +package org.apache.kafka.storage.internals.log; + +import org.apache.kafka.common.internals.FatalExitError; +import org.apache.kafka.common.utils.Exit; +import org.apache.kafka.common.utils.LogContext; +import org.slf4j.Logger; + +import java.util.concurrent.LinkedBlockingQueue; +import java.util.concurrent.ThreadFactory; +import java.util.concurrent.ThreadPoolExecutor; +import java.util.concurrent.TimeUnit; +import java.util.concurrent.atomic.AtomicInteger; + +public class RemoteStorageThreadPool extends ThreadPoolExecutor { + private final Logger logger; + + public RemoteStorageThreadPool(String threadNamePrefix, + int numThreads, + int maxPendingTasks) { + super(numThreads, numThreads, 0L, TimeUnit.MILLISECONDS, new LinkedBlockingQueue<>(maxPendingTasks), + new RemoteStorageThreadFactory(threadNamePrefix)); + logger = new LogContext() { + @Override + public String logPrefix() { Review Comment: @chia7712 I think it was added as part of `logPrefix()` method implementation but not as part of the constructor because the logger should have the invoking thread name as the prefix but not the thread name that created this thread pool. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
