cmccabe commented on code in PR #16183:
URL: https://github.com/apache/kafka/pull/16183#discussion_r1685017655
##########
core/src/main/scala/kafka/server/BrokerLifecycleManager.scala:
##########
@@ -381,10 +381,12 @@ class BrokerLifecycleManager(
private def sendBrokerRegistration(): Unit = {
val features = new BrokerRegistrationRequestData.FeatureCollection()
_supportedFeatures.asScala.foreach {
- case (name, range) => features.add(new
BrokerRegistrationRequestData.Feature().
+ // Do not include features with the range 0-0.
+ case (name, range) if range.max() > 0 => features.add(new
BrokerRegistrationRequestData.Feature().
Review Comment:
@jolshan : If you think it's easier to just omit them from the map, that's
fine.
I still think we should be checking that these things don't exist later on
(and for example, throw an exception if they do) to avoid regressions if
someone changes something (as has been happening a lot lately. :) )
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
