jolshan commented on code in PR #16619:
URL: https://github.com/apache/kafka/pull/16619#discussion_r1681705037
##########
core/src/test/scala/integration/kafka/api/ProducerIdExpirationTest.scala:
##########
@@ -137,9 +137,6 @@ class ProducerIdExpirationTest extends
KafkaServerTestHarness {
producer.send(TestUtils.producerRecordWithExpectedTransactionStatus(topic1, 0,
"4", "4", willBeCommitted = true))
producer.send(TestUtils.producerRecordWithExpectedTransactionStatus(topic1, 0,
"3", "3", willBeCommitted = true))
- // Producer IDs should be retained.
- assertEquals(1, producerState.size)
Review Comment:
One alternative I thought of is having this assertion just say the state is
greater than 0. Did we see any flakes indicate the size was 0?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
