[ 
https://issues.apache.org/jira/browse/KAFKA-17070?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17866356#comment-17866356
 ] 

Francesco Nigro commented on KAFKA-17070:
-----------------------------------------

Hi! I've added few comments to [https://github.com/apache/kafka/pull/16595] - I 
suggest to write a JMH micro which is easier to observate and verify that "it 
really matter" what the class is doing!

> perf: consider to use ByteBufferOutputstream to append records
> --------------------------------------------------------------
>
>                 Key: KAFKA-17070
>                 URL: https://issues.apache.org/jira/browse/KAFKA-17070
>             Project: Kafka
>          Issue Type: Improvement
>            Reporter: Luke Chen
>            Assignee: dujian0068
>            Priority: Major
>         Attachments: ByteBufferOutpuStream-Testresult.txt, 
> DataOutputStream-TestResult.txt, MyProducerTest.java
>
>
> Consider to use ByteBufferOutputstream to append records, instead of a 
> DataOutputStream. We should add JMH test to confirm this indeed improve the 
> performance before merging it.



--
This message was sent by Atlassian Jira
(v8.20.10#820010)

Reply via email to