masonyc commented on code in PR #16563:
URL: https://github.com/apache/kafka/pull/16563#discussion_r1676751571
##########
raft/src/test/java/org/apache/kafka/raft/KafkaRaftClientTest.java:
##########
@@ -746,9 +764,9 @@ public void
testCannotResignWithLargerEpochThanCurrentEpoch(boolean withKip853Rp
@ParameterizedTest
@ValueSource(booleans = { true, false })
public void testCannotResignIfNotLeader(boolean withKip853Rpc) throws
Exception {
- int localId = 0;
- int otherNodeId = 1;
- int leaderEpoch = 2;
+ int localId = randomReplicaId();
+ int otherNodeId = localId + 1;
+ int leaderEpoch = localId + 2;
Review Comment:
yep, nice catch! updated in latest commit
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
