[
https://issues.apache.org/jira/browse/KAFKA-17112?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17865080#comment-17865080
]
Ao Li commented on KAFKA-17112:
-------------------------------
Yes, I'm happy to submit a patch. I'm thinking of two potential fixes:
1. extend the `shutdown()` method to `shutdown(boolean forceCleanup)`.
{code}
public void shutdown(boolean forceCleanup) {
log.info("Informed to shut down");
final State oldState = setState(State.PENDING_SHUTDOWN);
if (oldState == State.CREATED || forceCleanup) {
// The thread may not have been started. Take responsibility for
shutting down
completeShutdown(true);
}
}
{code}
2. make `completeShutdown` public and directly call it from the test.
Which one do you think is better?
> StreamThread shutdown calls completeShutdown only in CREATED state
> ------------------------------------------------------------------
>
> Key: KAFKA-17112
> URL: https://issues.apache.org/jira/browse/KAFKA-17112
> Project: Kafka
> Issue Type: Bug
> Components: streams, unit tests
> Affects Versions: 3.9.0
> Reporter: Ao Li
> Priority: Minor
>
> While running tests in `StreamThreadTest.java` in kafka/streams, I noticed
> the test left many lingering threads. Though the class runs `shutdown` after
> each test, the shutdown only executes `completeShutdown` if the StreamThread
> is in CREATED state. See
> [https://github.com/apache/kafka/blob/0b11971f2c94f7aadc3fab2c51d94642065a72e5/streams/src/test/java/org/apache/kafka/streams/processor/internals/StreamThreadTest.java#L231]
> and
> [https://github.com/apache/kafka/blob/0b11971f2c94f7aadc3fab2c51d94642065a72e5/streams/src/main/java/org/apache/kafka/streams/processor/internals/StreamThread.java#L1435]
>
> For example, you may run test
> org.apache.kafka.streams.processor.internals.StreamThreadTest#shouldNotCloseTaskProducerWhenSuspending
> with commit 0b11971f2c94f7aadc3fab2c51d94642065a72e5. When the test calls
> `thread.shutdown()`, the thread is in `PARTITIONS_REVOKED` state. Thus,
> `completeShutdown` is not called. The test creates three lingering threads: 2
> `StateUpdater` and 1 `TaskExecutor`
>
> This means that calls to `thread.shutdown` has no effect in
> `StreamThreadTest.java`.
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
