mjsax commented on code in PR #16391:
URL: https://github.com/apache/kafka/pull/16391#discussion_r1673180484
##########
docs/streams/developer-guide/config-streams.html:
##########
@@ -689,7 +689,7 @@ <h4><a class="toc-backref"
href="#id9">default.value.serde</a><a class="headerli
</div></blockquote>
</div>
<div class="section" id="default-windowed-key-serde-inner">
- <h4><a class="toc-backref"
href="#id32">default.windowed.key.serde.inner</a><a class="headerlink"
href="#default-windowed-key-serde-inner" title="Permalink to this
headline"></a> (Deprecated.)</h4>
+ <h4><a class="toc-backref"
href="#id32">default.windowed.key.serde.inner</a><a class="headerlink"
href="#default-windowed-key-serde-inner" title="Permalink to this
headline"></a>(Deprecated.)</h4>
Review Comment:
Why remove the space?
##########
docs/streams/developer-guide/config-streams.html:
##########
@@ -243,19 +243,19 @@ <h4><a class="toc-backref"
href="#id23">num.standby.replicas</a><a class="header
</tr>
</thead>
<tbody valign="top">
- <tr class="row-even"><td>acceptable.recovery.lag</td>
+ <tr class="row-odd"><td>acceptable.recovery.lag</td>
Review Comment:
Why do we change this? Seem the top row with "Parameter Name" is `odd`
already, so `even` seems to be correct here?
##########
docs/streams/developer-guide/config-streams.html:
##########
@@ -1039,7 +1045,7 @@ <h4><a class="toc-backref"
href="#id31">topology.optimization</a><a class="heade
<blockquote>
<div>
<p>
- A configuration telling Kafka Streams if it should optimize the
topology and what optimizations to apply. Acceptable values are:
<code>StreamsConfig.NO_OPTIMIZATION</code> (<code>none</code>),
<code>StreamsConfig.OPTIMIZE</code> (<code>all</code>) or a comma separated
list of specific optimizations:
<code>StreamsConfig.REUSE_KTABLE_SOURCE_TOPICS</code>
(<code>reuse.ktable.source.topics</code>),
<code>StreamsConfig.MERGE_REPARTITION_TOPICS</code>
(<code>merge.repartition.topics</code>),
<code>StreamsConfig.SINGLE_STORE_SELF_JOIN</code>
(<code>single.store.self.join</code>).
+ A configuration telling Kafka Streams if it should optimize the
topology and what optimizations to apply. Acceptable values are:
<code>StreamsConfig.NO_OPTIMIZATION</code> (<code>none</code>),
<code>StreamsConfig.OPTIMIZE</code> (<code>all</code>) or a comma separated
list of specific optimizations:
(<code>StreamsConfig.REUSE_KTABLE_SOURCE_TOPICS</code>
(<code>reuse.ktable.source.topics</code>),
<code>StreamsConfig.MERGE_REPARTITION_TOPICS</code>
(<code>merge.repartition.topics</code>)).
Review Comment:
Why do we remove this option? Seems not related to this PR (and also not
necessary -- this option is valid).
##########
docs/streams/developer-guide/config-streams.html:
##########
@@ -713,6 +713,12 @@ <h4><a class="toc-backref"
href="#id33">default.windowed.value.serde.inner</a><a
<p>This is discussed in more detail in <a class="reference
internal" href="datatypes.html#streams-developer-guide-serdes"><span class="std
std-ref">Data types and serialization</span></a>.</p>
</div></blockquote>
</div>
+ <div class="section" id="windowed-inner-class-serde">
+ <h4><a class="toc-backref"
href="#id39">windowed.inner.class.serde</a><a class="headerlink"
href="#windowed-inner-class-serde" title="Permalink to this
headline"></a>(Deprecated.)</h4>
Review Comment:
```suggestion
<h4><a class="toc-backref"
href="#id39">windowed.inner.class.serde</a><a class="headerlink"
href="#windowed-inner-class-serde" title="Permalink to this headline"></a>
(Deprecated.)</h4>
```
##########
docs/streams/developer-guide/config-streams.html:
##########
@@ -713,6 +713,12 @@ <h4><a class="toc-backref"
href="#id33">default.windowed.value.serde.inner</a><a
<p>This is discussed in more detail in <a class="reference
internal" href="datatypes.html#streams-developer-guide-serdes"><span class="std
std-ref">Data types and serialization</span></a>.</p>
</div></blockquote>
</div>
+ <div class="section" id="windowed-inner-class-serde">
+ <h4><a class="toc-backref"
href="#id39">windowed.inner.class.serde</a><a class="headerlink"
href="#windowed-inner-class-serde" title="Permalink to this
headline"></a>(Deprecated.)</h4>
+ <blockquote>
+ <div><p>The default Serializer/Deserializer class for the inner
class of a windowed record. Must implement the <code class="docutils
literal"><span class="pre">org.apache.kafka.common.serialization.Serde
</span></code> interface. Note that setting this config in KafkaStreams
application would result in an error as it is meant to be used only from Plain
consumer client.</p>
Review Comment:
```suggestion
<div><p>The default Serializer/Deserializer class for the inner
class of a windowed record. Must implement the <code class="docutils
literal"><span
class="pre">org.apache.kafka.common.serialization.Serde</span></code>
interface. Note that setting this config in KafkaStreams application would
result in an error as it is meant to be used only from Plain consumer
client.</p>
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
