ahuang98 commented on code in PR #16346:
URL: https://github.com/apache/kafka/pull/16346#discussion_r1672981769
##########
clients/src/main/java/org/apache/kafka/common/network/SaslChannelBuilder.java:
##########
@@ -190,9 +191,13 @@ public Set<String> reconfigurableConfigs() {
}
@Override
- public void validateReconfiguration(Map<String, ?> configs) {
+ public void validateReconfiguration(Map<String, ?> configs) throws
ConfigException {
if (this.securityProtocol == SecurityProtocol.SASL_SSL)
- sslFactory.validateReconfiguration(configs);
+ try {
+ sslFactory.validateReconfiguration(configs);
+ } catch (IllegalStateException e) {
+ throw new ConfigException("SASL reconfiguration failed due to
" + e);
Review Comment:
I'm concatenating the "SASL reconfiguration failed" message with the
underlying exception string now since it looks like `ConfigException` will
print errors in a very specific way
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
