chia7712 commented on code in PR #16559:
URL: https://github.com/apache/kafka/pull/16559#discussion_r1672696342
##########
build.gradle:
##########
@@ -1211,6 +1211,7 @@ project(':core') {
//By default gradle does not handle test dependencies between the
sub-projects
//This line is to include clients project test jar to dependant-testlibs
from (project(':clients').testJar ) { "$buildDir/dependant-testlibs" }
+ from (project(':log4j-appender').jar ) { "$buildDir/dependant-testlibs" }
Review Comment:
Please add comments for it
##########
tests/kafkatest/services/kafka_log4j_appender.py:
##########
@@ -48,7 +49,10 @@ def _worker(self, idx, node):
node.account.ssh(cmd)
def start_cmd(self, node):
+ core_dependant_test_libs_jar =
self.path.jar(CORE_DEPENDANT_TEST_LIBS_JAR_NAME, DEV_BRANCH)
cmd = fix_opts_for_new_jvm(node)
+ cmd += "for file in %s; do CLASSPATH=$CLASSPATH:$file; done;" %
core_dependant_test_libs_jar
Review Comment:
ditto
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
