junrao commented on code in PR #16421:
URL: https://github.com/apache/kafka/pull/16421#discussion_r1672625806


##########
tools/src/test/java/org/apache/kafka/tools/FeatureCommandTest.java:
##########
@@ -67,8 +67,10 @@ public void testDescribeWithKRaft(ClusterInstance cluster) {
         List<String> features = 
Arrays.stream(commandOutput.split("\n")).sorted().collect(Collectors.toList());
 
         // Change expected message to reflect latest MetadataVersion 
(SupportedMaxVersion increases when adding a new version)
+        assertEquals("Feature: kraft.version\tSupportedMinVersion: 0\t" +
+                "SupportedMaxVersion: 1\tFinalizedVersionLevel: 0\t", 
outputWithoutEpoch(features.get(0)));

Review Comment:
   How does this test work? Do we explicitly set the FinalizedVersionLevel for 
kraft.version to 0 somewhere?



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to