apoorvmittal10 commented on code in PR #16456:
URL: https://github.com/apache/kafka/pull/16456#discussion_r1672111524
##########
core/src/test/scala/unit/kafka/server/KafkaApisTest.scala:
##########
@@ -4390,6 +4401,2215 @@ class KafkaApisTest extends Logging {
assertEquals("broker2", node.host)
}
+ private def expectedAcquiredRecords(firstOffset : Long, lastOffset : Long,
deliveryCount : Int) : util.List[AcquiredRecords] = {
Review Comment:
it's not that important but generally the helper method will come post the
usage i.e. test -> helper method.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
