chia7712 commented on code in PR #16506:
URL: https://github.com/apache/kafka/pull/16506#discussion_r1671289997
##########
server/src/main/java/org/apache/kafka/server/config/ShareGroupConfig.java:
##########
@@ -100,4 +102,124 @@ public class ShareGroupConfigs {
.define(SHARE_GROUP_MAX_HEARTBEAT_INTERVAL_MS_CONFIG, INT,
SHARE_GROUP_MAX_HEARTBEAT_INTERVAL_MS_DEFAULT, atLeast(1), MEDIUM,
SHARE_GROUP_MAX_HEARTBEAT_INTERVAL_MS_DOC)
.define(SHARE_GROUP_MAX_GROUPS_CONFIG, SHORT,
SHARE_GROUP_MAX_GROUPS_DEFAULT, between(1, 100), MEDIUM,
SHARE_GROUP_MAX_GROUPS_DOC)
.define(SHARE_GROUP_MAX_SIZE_CONFIG, SHORT,
SHARE_GROUP_MAX_SIZE_DEFAULT, between(10, 1000), MEDIUM,
SHARE_GROUP_MAX_SIZE_DOC);
+
+ private final Boolean isShareGroupEnabled;
+ private final int shareGroupPartitionMaxRecordLocks;
+ private final int shareGroupDeliveryCountLimit;
+ private final short shareGroupMaxGroups;
+ private final short shareGroupMaxSize;
+ private final int shareGroupSessionTimeoutMs;
+ private final int shareGroupMinSessionTimeoutMs;
+ private final int shareGroupMaxSessionTimeoutMs;
+ private final int shareGroupHeartbeatIntervalMs;
+ private final int shareGroupMinHeartbeatIntervalMs;
+ private final int shareGroupMaxHeartbeatIntervalMs;
+ private final int shareGroupRecordLockDurationMs;
+ private final int shareGroupMaxRecordLockDurationMs;
+ private final int shareGroupMinRecordLockDurationMs;
+
+ public ShareGroupConfig(AbstractConfig config) {
+ isShareGroupEnabled =
config.getBoolean(ShareGroupConfig.SHARE_GROUP_ENABLE_CONFIG);
+ shareGroupPartitionMaxRecordLocks =
config.getInt(ShareGroupConfig.SHARE_GROUP_PARTITION_MAX_RECORD_LOCKS_CONFIG);
+ shareGroupDeliveryCountLimit =
config.getInt(ShareGroupConfig.SHARE_GROUP_DELIVERY_COUNT_LIMIT_CONFIG);
+ shareGroupMaxGroups =
config.getShort(ShareGroupConfig.SHARE_GROUP_MAX_GROUPS_CONFIG);
+ shareGroupSessionTimeoutMs =
config.getInt(ShareGroupConfig.SHARE_GROUP_SESSION_TIMEOUT_MS_CONFIG);
+ shareGroupMinSessionTimeoutMs =
config.getInt(ShareGroupConfig.SHARE_GROUP_MIN_SESSION_TIMEOUT_MS_CONFIG);
+ shareGroupMaxSessionTimeoutMs =
config.getInt(ShareGroupConfig.SHARE_GROUP_MAX_SESSION_TIMEOUT_MS_CONFIG);
+ shareGroupHeartbeatIntervalMs =
config.getInt(ShareGroupConfig.SHARE_GROUP_HEARTBEAT_INTERVAL_MS_CONFIG);
+ shareGroupMinHeartbeatIntervalMs =
config.getInt(ShareGroupConfig.SHARE_GROUP_MIN_HEARTBEAT_INTERVAL_MS_CONFIG);
+ shareGroupMaxHeartbeatIntervalMs =
config.getInt(ShareGroupConfig.SHARE_GROUP_MAX_HEARTBEAT_INTERVAL_MS_CONFIG);
+ shareGroupRecordLockDurationMs =
config.getInt(ShareGroupConfig.SHARE_GROUP_RECORD_LOCK_DURATION_MS_CONFIG);
+ shareGroupMaxRecordLockDurationMs =
config.getInt(ShareGroupConfig.SHARE_GROUP_MAX_RECORD_LOCK_DURATION_MS_CONFIG);
+ shareGroupMinRecordLockDurationMs =
config.getInt(ShareGroupConfig.SHARE_GROUP_MIN_RECORD_LOCK_DURATION_MS_CONFIG);
+ shareGroupMaxSize =
config.getShort(ShareGroupConfig.SHARE_GROUP_MAX_SIZE_CONFIG);
+ validate();
+ }
+
+ /** Share group configuration **/
+ Boolean isShareGroupEnabled() {
Review Comment:
`boolean`
##########
server/src/main/java/org/apache/kafka/server/config/ShareGroupConfig.java:
##########
@@ -100,4 +102,124 @@ public class ShareGroupConfigs {
.define(SHARE_GROUP_MAX_HEARTBEAT_INTERVAL_MS_CONFIG, INT,
SHARE_GROUP_MAX_HEARTBEAT_INTERVAL_MS_DEFAULT, atLeast(1), MEDIUM,
SHARE_GROUP_MAX_HEARTBEAT_INTERVAL_MS_DOC)
.define(SHARE_GROUP_MAX_GROUPS_CONFIG, SHORT,
SHARE_GROUP_MAX_GROUPS_DEFAULT, between(1, 100), MEDIUM,
SHARE_GROUP_MAX_GROUPS_DOC)
.define(SHARE_GROUP_MAX_SIZE_CONFIG, SHORT,
SHARE_GROUP_MAX_SIZE_DEFAULT, between(10, 1000), MEDIUM,
SHARE_GROUP_MAX_SIZE_DOC);
+
+ private final Boolean isShareGroupEnabled;
Review Comment:
`boolean`
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
