cmccabe commented on code in PR #16421:
URL: https://github.com/apache/kafka/pull/16421#discussion_r1671020455


##########
clients/src/main/resources/common/message/ApiVersionsResponse.json:
##########
@@ -45,7 +47,7 @@
       "about": "The duration in milliseconds for which the request was 
throttled due to a quota violation, or zero if the request did not violate any 
quota." },
     { "name":  "SupportedFeatures", "type": "[]SupportedFeatureKey", 
"ignorable": true,
       "versions":  "3+", "tag": 0, "taggedVersions": "3+",
-      "about": "Features supported by the broker.",
+      "about": "Features supported by the broker. Note: in v0-v3, features 
with MinSupportedVersion = 0 must be left out.",

Review Comment:
   > This needs to be adjusted accordingly since we now keep the feature but 
returns 1 as the minSupportedVersion.
   
   done



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to