[
https://issues.apache.org/jira/browse/KAFKA-17095?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17863910#comment-17863910
]
Chia-Ping Tsai commented on KAFKA-17095:
----------------------------------------
[~gharris1727] thanks for response.
{quote}
Is this a backwards compatible change? If someone with the old definition
connects to a broker with the new definition, do the two interoperate?
{quote}
This is related to RPC binary compatibility, and I believe the renaming should
not break it. There were similar renaming issue
[https://github.com/apache/kafka/commit/7c8c65fc54b9eb0386787632ff8315e097d99818|https://github.com/apache/kafka/commit/7c8c65fc54b9eb0386787632ff8315e097d99818)]
[https://github.com/apache/kafka/commit/e00c0d316db01fbe5e57a4dfd54856c89e761b08]
{quote}
If someone is relying on the generated type directly, does this break
compilation?
{quote}
This is definitely a good question to me.
I try to find out the evidence/statement to ensure whether generated code
(signature) are public to users. The doc
([https://cwiki.apache.org/confluence/display/KAFKA/Kafka+Improvement+Proposals)]
says "Any class for which the build generates Javadoc.", but the generated
code are not there
([https://github.com/apache/kafka/blob/trunk/build.gradle#L1661)]
If the generated code (on client side) are indeed public to users, I'm to close
this Jira and file another one to complete the docs (maybe Kafka KIP page) to
remind all of us that DON"T introduce changes to the method signature.
> Fix the typo: CreateableTopicConfig -> CreatableTopicConfig
> -----------------------------------------------------------
>
> Key: KAFKA-17095
> URL: https://issues.apache.org/jira/browse/KAFKA-17095
> Project: Kafka
> Issue Type: Improvement
> Reporter: Chia-Ping Tsai
> Assignee: Ming-Yen Chung
> Priority: Minor
>
> source:
> https://github.com/apache/kafka/blob/trunk/clients/src/main/resources/common/message/CreateTopicsRequest.json#L51
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
