OmniaGM commented on code in PR #15999:
URL: https://github.com/apache/kafka/pull/15999#discussion_r1664131813
##########
connect/mirror/src/main/java/org/apache/kafka/connect/mirror/MirrorCheckpointConnector.java:
##########
@@ -106,6 +108,17 @@ public void stop() {
Utils.closeQuietly(targetAdminClient, "target admin client");
}
+ @Override
+ public Config validate(Map<String, String> connectorConfigs) {
+ List<ConfigValue> configValues =
super.validate(connectorConfigs).configValues();
+ MirrorCheckpointConfig.validate(connectorConfigs).forEach((config,
errorMsg) ->
+ configValues.stream()
+ .filter(conf -> conf.name().equals(config))
+ .forEach(conf -> conf.errorMessages().add(errorMsg)));
Review Comment:
updated this. Forgot to roll it back to addErrorMessage when addressing some
of other feedbacks
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
