junrao commented on code in PR #16420:
URL: https://github.com/apache/kafka/pull/16420#discussion_r1653240450
##########
clients/src/main/java/org/apache/kafka/common/requests/ApiVersionsResponse.java:
##########
@@ -258,11 +259,22 @@ private static ApiVersionsResponseData
createApiVersionsResponseData(
final long finalizedFeaturesEpoch,
final boolean zkMigrationEnabled
) {
+ Features<SupportedVersionRange> backwardsCompatibleFeatures =
Features.supportedFeatures(latestSupportedFeatures.features().entrySet()
+ .stream().filter(entry -> {
+ SupportedVersionRange supportedVersionRange = entry.getValue();
+ return supportedVersionRange.min() != 0;
Review Comment:
Perhaps it's useful to add a comment on why we are filtering version 0
features.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
