gharris1727 commented on code in PR #16095:
URL: https://github.com/apache/kafka/pull/16095#discussion_r1644895138
##########
connect/runtime/src/main/java/org/apache/kafka/connect/runtime/WorkerConnector.java:
##########
@@ -307,7 +307,7 @@ void doShutdown() {
+ " as the connector has been scheduled
for shutdown"),
null);
}
- if (state == State.STARTED)
+ if (state == State.STARTED || state == State.FAILED)
connector.stop();
Review Comment:
I think that some of the tests in WorkerConnectorTest exercising failed
connectors will need some verifyCleanShutdown assertions updated. A test which
tests exceptions in both start() and stop() would also be very helpful :)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
