OmniaGM commented on code in PR #15968:
URL: https://github.com/apache/kafka/pull/15968#discussion_r1644094646
##########
clients/src/test/java/org/apache/kafka/common/requests/ProduceRequestTest.java:
##########
@@ -120,15 +121,38 @@ public void testBuildWithCurrentMessageFormat() {
ProduceRequest.Builder requestBuilder =
ProduceRequest.forMagic(RecordBatch.CURRENT_MAGIC_VALUE,
new ProduceRequestData()
.setTopicData(new
ProduceRequestData.TopicProduceDataCollection(Collections.singletonList(
- new
ProduceRequestData.TopicProduceData().setName("test").setPartitionData(Collections.singletonList(
- new
ProduceRequestData.PartitionProduceData().setIndex(9).setRecords(builder.build()))))
+ new
ProduceRequestData.TopicProduceData()
+ .setName("test")
Review Comment:
No we don't have a case where we will write both. However if we passed both
the request will drop the name with version >= 12. I'll remove `setName` from
this test so we don't give the wrong impression that we are expecting both
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
