chia7712 commented on code in PR #16351:
URL: https://github.com/apache/kafka/pull/16351#discussion_r1642052004
##########
connect/runtime/src/test/java/org/apache/kafka/connect/runtime/ErrorHandlingTaskTest.java:
##########
@@ -179,19 +176,15 @@ public class ErrorHandlingTaskTest {
private ErrorHandlingMetrics errorHandlingMetrics;
- private final boolean enableTopicCreation;
+ private boolean enableTopicCreation;
- @Parameterized.Parameters
public static Collection<Boolean> parameters() {
Review Comment:
this is unused now, right?
##########
connect/runtime/src/test/java/org/apache/kafka/connect/runtime/ExactlyOnceWorkerSourceTaskTest.java:
##########
@@ -174,23 +171,20 @@ public class ExactlyOnceWorkerSourceTaskTest {
private final AtomicReference<CountDownLatch> pollLatch = new
AtomicReference<>(new CountDownLatch(0));
private final AtomicReference<List<SourceRecord>> pollRecords = new
AtomicReference<>(RECORDS);
- private final boolean enableTopicCreation;
+ private boolean enableTopicCreation;
private boolean taskStarted;
private Future<?> workerTaskFuture;
- @ParameterizedTest.Parameters
- public static Collection<Boolean> parameters() {
- return Arrays.asList(false, true);
+
+ public static Stream<Boolean> parameters() {
Review Comment:
ditto
##########
connect/runtime/src/test/java/org/apache/kafka/connect/runtime/WorkerConnectorTest.java:
##########
@@ -77,25 +75,22 @@ public class WorkerConnectorTest {
public ConnectorConfig connectorConfig;
public MockConnectMetrics metrics;
- @Rule
- public MockitoRule rule =
MockitoJUnit.rule().strictness(Strictness.STRICT_STUBS);
@Mock private Plugins plugins;
@Mock private CloseableConnectorContext ctx;
@Mock private ConnectorStatus.Listener listener;
@Mock private ClassLoader classLoader;
- private final ConnectorType connectorType;
- private final Connector connector;
- private final CloseableOffsetStorageReader offsetStorageReader;
- private final ConnectorOffsetBackingStore offsetStore;
+ private ConnectorType connectorType;
+ private Connector connector;
+ private CloseableOffsetStorageReader offsetStorageReader;
+ private ConnectorOffsetBackingStore offsetStore;
- @Parameterized.Parameters
public static Collection<ConnectorType> parameters() {
Review Comment:
ditto
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
