tinaselenge commented on code in PR #15175:
URL: https://github.com/apache/kafka/pull/15175#discussion_r1640059705
##########
core/src/test/scala/integration/kafka/api/SslAdminIntegrationTest.scala:
##########
@@ -42,6 +42,7 @@ object SslAdminIntegrationTest {
@volatile var lastUpdateRequestContext: Option[AuthorizableRequestContext] =
None
Review Comment:
The tests in this file test async Authorizer by using semaphore to block
request threads. The functions used for this, don't work with KRaft at the
moment (I get various failure from request not being blocked as expected or
`This function can't be accessed when running the test in KRaft mode. ZooKeeper
mode is required.` error). I think the changes required to enable KRaft for
this file, would be quite different than the other ones so I think it's better
to be done in separate PRs. Also this was left out from the Jira issues created
for the initial tests to be enabled with KRaft before 4.0, so I don't know if
there was any particular reason for that.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
