mimaison commented on code in PR #16324:
URL: https://github.com/apache/kafka/pull/16324#discussion_r1638540861
##########
gradle/dependencies.gradle:
##########
@@ -237,6 +237,7 @@ libs += [
pcollections: "org.pcollections:pcollections:$versions.pcollections",
opentelemetryProto:
"io.opentelemetry.proto:opentelemetry-proto:$versions.opentelemetryProto",
reflections: "org.reflections:reflections:$versions.reflections",
+ reload4j: "org.slf4j:slf4j-reload4j:$versions.slf4j",
Review Comment:
It's a bit confusing to name this `reload4j` as we already have
`versions.reload4j` defined.
Can this be named `slf4j-reload4j`?
I wonder if we can also rename `log4j` to `reload4j` to avoid confusions.
##########
build.gradle:
##########
@@ -2175,7 +2176,7 @@ project(':tools') {
implementation libs.jacksonDataformatCsv
implementation libs.jacksonJDK8Datatypes
implementation libs.slf4jApi
- implementation libs.slf4jlog4j
Review Comment:
Could we replace slf4jlog4j with slf4j-reload4j evrywhere, and remove
libs.slf4jlog4j altogether?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
