chia7712 commented on code in PR #16304:
URL: https://github.com/apache/kafka/pull/16304#discussion_r1636713882
##########
clients/src/main/java/org/apache/kafka/clients/consumer/internals/ConsumerNetworkThread.java:
##########
@@ -207,8 +207,7 @@ private void reapExpiredApplicationEvents(long
currentTimeMs) {
*/
// Visible for testing
static void runAtClose(final Collection<Optional<? extends
RequestManager>> requestManagers,
- final NetworkClientDelegate networkClientDelegate,
- final Timer timer) {
Review Comment:
I guess this timer was expected to be used by `pollOnClose`. It seems to me
`pollOnClose` should take a `timeout`, so the request managers has the chance
to return on time in the future.
For another, the `timer` should call `timer.update()` at the end. Otherwise,
the later operations (`sendUnsentRequests`) will get incorrect remaining
timeout.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
