mimaison commented on code in PR #16136:
URL: https://github.com/apache/kafka/pull/16136#discussion_r1635939546


##########
clients/src/main/java/org/apache/kafka/clients/admin/KafkaAdminClient.java:
##########
@@ -2404,14 +2404,16 @@ void handleFailure(Throwable throwable) {
 
     private TopicDescription 
getTopicDescriptionFromDescribeTopicsResponseTopic(
         DescribeTopicPartitionsResponseTopic topic,
-        Map<Integer, Node> nodes
+        Map<Integer, Node> nodes,
+        boolean includeAuthorizedOperations
     ) {
         List<DescribeTopicPartitionsResponsePartition> partitionInfos = 
topic.partitions();
         List<TopicPartitionInfo> partitions = new 
ArrayList<>(partitionInfos.size());
         for (DescribeTopicPartitionsResponsePartition partitionInfo : 
partitionInfos) {
             
partitions.add(DescribeTopicPartitionsResponse.partitionToTopicPartitionInfo(partitionInfo,
 nodes));
         }
-        return new TopicDescription(topic.name(), topic.isInternal(), 
partitions, validAclOperations(topic.topicAuthorizedOperations()), 
topic.topicId());
+        Set<AclOperation> authorisedOperations = includeAuthorizedOperations ? 
validAclOperations(topic.topicAuthorizedOperations()) : null;

Review Comment:
   This was briefly discussed in 
https://github.com/apache/kafka/pull/15175#issuecomment-2137870907 where we 
identified this issue.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to