gharris1727 commented on code in PR #16288:
URL: https://github.com/apache/kafka/pull/16288#discussion_r1635577975
##########
connect/runtime/src/test/java/org/apache/kafka/connect/integration/InternalTopicsIntegrationTest.java:
##########
@@ -169,7 +164,6 @@ public void
testFailToStartWhenInternalTopicsAreNotCompacted() throws Interrupte
// Start the brokers but not Connect
log.info("Starting {} Kafka brokers, but no Connect workers yet",
numBrokers);
connect.start();
Review Comment:
For downstream users intentionally giving the embedded connect bad configs,
they will need to alter the test anyway, so I'd prefer that they follow the
pattern used by upstream.
I don't think that anyone should really be relying on this behavior,
otherwise I would make an argument for start() remaining non-blocking (which i
definitely don't want).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
