chia7712 commented on code in PR #16266:
URL: https://github.com/apache/kafka/pull/16266#discussion_r1635508054
##########
clients/src/main/java/org/apache/kafka/common/utils/Time.java:
##########
@@ -30,7 +30,40 @@
*/
public interface Time {
- Time SYSTEM = new SystemTime();
+ // A time implementation that uses the system clock and sleep call.
+ // Use inline implementation to ensure that only one Time#SYSTEM exists
in a program
+ Time SYSTEM = new Time() {
Review Comment:
> You could leave the existing class in-place and make it package-local, or
make this an inner class.
As `Timer` is a interface, inner class has public modifier by default. Hence
+1 to make it package-private - `public class SystemTime` -> `class SystemTime`
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
