ableegoldman commented on code in PR #16292:
URL: https://github.com/apache/kafka/pull/16292#discussion_r1635437280


##########
streams/src/main/java/org/apache/kafka/streams/processor/assignment/assignors/StickyTaskAssignor.java:
##########
@@ -105,6 +105,8 @@ private void optimizeActive(final ApplicationState 
applicationState,
             .filter(task -> !task.isStateful())
             .map(TaskInfo::id)
             .collect(Collectors.toSet());
+
+        // TODO: We need to use stateless traffic costs and non overlap costs 
here.

Review Comment:
   You should probably take this out just because you're already working on the 
PR that addresses this, and would have to rebase it to remove the TODO comment 
when  this PR is merged which means retriggering the build on your other PR in 
like 4 hours



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to