showuon commented on code in PR #15820:
URL: https://github.com/apache/kafka/pull/15820#discussion_r1634689117
##########
core/src/main/java/kafka/log/remote/RemoteLogManager.java:
##########
@@ -738,6 +750,23 @@ public void copyLogSegmentsToRemote(UnifiedLog log) throws
InterruptedException
isCancelled(), isLeader());
return;
}
+
+ copyQuotaManagerLock.lock();
+ try {
+ while (rlmCopyQuotaManager.isQuotaExceeded()) {
Review Comment:
@abhijeetk88 , thanks for the response. I agree we can keep it as is, and
just document it clearly in monitoring section:
https://kafka.apache.org/documentation/#monitoring . We can improve it in the
future if necessary.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
