gharris1727 commented on PR #16143: URL: https://github.com/apache/kafka/pull/16143#issuecomment-2159265832
Okay thank you for the clarification @anton-liauchuk . While avoiding confusing one operation for another by turning off all-but-one operation avoids the ambiguity, it still leaves the opportunity for ambiguity to appear in the future. If we are avoiding certain situations due to ambiguity, that reduces our total test coverage. Also I think `testCreatePartitionsUseProvidedForwardingAdmin` remains ambiguous, at least from re-reading my original comment: https://github.com/apache/kafka/pull/13575#issuecomment-1513825281 > I had to implement `incrementalAlterConfigs` Thanks, that definitely needed to be done. FakeLocalMetadataStore should have the granularity to assert that we used incremental vs the legacy API, and it doesn't right now. That would have caught this mistake earlier when MM2 support for the new API was added. Please refactor the FakeLocalMetadata store to make the ambiguity impossible, thanks! -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
