showuon opened a new pull request, #16260:
URL: https://github.com/apache/kafka/pull/16260

   In https://github.com/apache/kafka/pull/12148 , we removed log4jAppender 
dependency, and add testImplementation dependency for `slf4jlog4j` lib. 
However, we need this runtime dependency in tools module to output logs. 
([ref](https://stackoverflow.com/a/21787813)) Adding this dependency back.
   
   Current output will be like this:
   
   ```
   > bin/kafka-server-start.sh config/kraft/controller.properties
   SLF4J: Failed to load class "org.slf4j.impl.StaticLoggerBinder".
   SLF4J: Defaulting to no-operation (NOP) logger implementation
   SLF4J: See http://www.slf4j.org/codes.html#StaticLoggerBinder for further 
details.
   ```
   
   After this PR, it'll be normal:
   ```
   > bin/kafka-server-start.sh config/kraft/controller.properties 
   [2024-06-10 08:38:50,734] INFO Registered kafka:type=kafka.Log4jController 
MBean (kafka.utils.Log4jControllerRegistration$)
   [2024-06-10 08:38:50,832] INFO Setting -D 
jdk.tls.rejectClientInitiatedRenegotiation=true to disable client-initiated TLS 
renegotiation (org.apache.zookeeper.common.X509Util)
   ...
   ```
   
   
   ### Committer Checklist (excluded from commit message)
   - [ ] Verify design and implementation 
   - [ ] Verify test coverage and CI build status
   - [ ] Verify documentation (including upgrade notes)
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to