soarez opened a new pull request, #16251: URL: https://github.com/apache/kafka/pull/16251
KAFKA-16606 (#15834) introduced a change that broke ReassignPartitionsCommandTest.testReassignmentCompletionDuringPartialUpgrade. The point was to validate that the MetadataVersion supports JBOD in KRaft when multiple log directories are configured. We do that by checking the version used in kafka-features.sh upgrade --metadata, and the version discovered via a FeatureRecord for metadata.version in the cluster metadata. There's no point in checking inter.broker.protocol.version in KafkaConfig, since in KRaft, that configuration is deprecated and ignored — always assuming the value of MINIMUM_KRAFT_VERSION. The broken that was broken sets inter.broker.protocol.version in KRaft mode and configures 3 directories. So alternatively, we could change the test to not configure this property. Since the property isn't forbidden in KRaft mode, just ignored, and operators may forget to remove it, it seems better to remote the fail condition in KafkaConfig. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
