chia7712 commented on code in PR #16172:
URL: https://github.com/apache/kafka/pull/16172#discussion_r1629625646
##########
build.gradle:
##########
@@ -853,8 +851,8 @@ subprojects {
skipProjects = [ ":jmh-benchmarks", ":trogdor" ]
skipConfigurations = [ "zinc" ]
}
-
- if(JavaVersion.current().isJava11Compatible() && project.path !in
excludedSpotlessModules) {
+ // current spotless work error in JDK21,upgrade spotless version when kafka
drop support JDK8
Review Comment:
```
the task `removeUnusedImports` is implemented by google-java-format, and
unfortunately the google-java-format version used by spotless 6.14.0 can't work
with JDK 21. Hence, we apply spotless tasks only if the env is either JDK11 or
JDK17
```
WDYT?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
