dajac commented on code in PR #16198:
URL: https://github.com/apache/kafka/pull/16198#discussion_r1628386140
##########
group-coordinator/src/main/java/org/apache/kafka/coordinator/group/assignor/OptimizedUniformAssignmentBuilder.java:
##########
@@ -160,7 +166,7 @@ public GroupAssignment build() throws
PartitionAssignorException {
*/
private void maybeRevokePartitions() {
for (String memberId : groupSpec.memberIds()) {
- Map<Uuid, Set<Integer>> oldAssignment =
groupSpec.memberAssignment(memberId);
+ Map<Uuid, Set<Integer>> oldAssignment =
groupSpec.memberAssignment(memberId).partitions();
Review Comment:
We can probably do further improvements but this goes beyond the scope of
this PR. We can do them as follow-ups. Does it work for you?
Regarding the usage of raw maps, the assignors work with them at the moment
so we cannot change it easily. We are working hard on refactoring the assignors
to perform better. Once we are done with this, we can consider it. As the
interface will remain unstable until 4.0, we can still do it afterwards.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
