brandboat commented on code in PR #16202:
URL: https://github.com/apache/kafka/pull/16202#discussion_r1627848453
##########
storage/src/test/java/org/apache/kafka/server/log/remote/metadata/storage/RemoteLogMetadataFormatterTest.java:
##########
@@ -35,28 +34,29 @@
import java.util.Optional;
import static org.junit.jupiter.api.Assertions.assertEquals;
+import static
org.apache.kafka.server.log.remote.storage.RemoteLogSegmentState.COPY_SEGMENT_STARTED;
public class RemoteLogMetadataFormatterTest {
- private static final Uuid TOPIC_ID = Uuid.randomUuid();
Review Comment:
It's kind of grey zone to me. I'm not so sure why make it non-static.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
