chia7712 commented on code in PR #16204:
URL: https://github.com/apache/kafka/pull/16204#discussion_r1627822996
##########
shell/src/test/java/org/apache/kafka/shell/glob/GlobVisitorTest.java:
##########
@@ -99,11 +100,11 @@ public MetadataNode child(String name) {
}
static class InfoConsumer implements Consumer<Optional<MetadataNodeInfo>> {
- private Optional<List<MetadataNodeInfo>> infos = null;
+ private Optional<List<MetadataNodeInfo>> infos = Optional.empty();
Review Comment:
not sure why we need `Optional` ... it seems empty collection can be equal
to `Optional.empty`
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
