mimaison commented on code in PR #16065:
URL: https://github.com/apache/kafka/pull/16065#discussion_r1627273677
##########
metadata/src/test/java/org/apache/kafka/image/ImageDowngradeTest.java:
##########
@@ -103,7 +103,7 @@ public void testPremodernVersion() {
@Test
public void testPreControlledShutdownStateVersion() {
writeWithExpectedLosses(MetadataVersion.IBP_3_3_IV2,
- Arrays.asList(
+ Collections.singletonList(
Review Comment:
I meant shifting this whole block to the left so it's aligned like the
`testPremodernVersion()` and `testPreZkMigrationSupportVersion()` methods for
example.
My point is that consistency across similar methods is usually helpful and
improves readability, even if it's not necessarily the "recommended/best"
alignment.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
