[
https://issues.apache.org/jira/browse/KAFKA-16843?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
PoAn Yang resolved KAFKA-16843.
-------------------------------
Resolution: Fixed
> Remove preAppendErrors from createPutCacheCallback
> --------------------------------------------------
>
> Key: KAFKA-16843
> URL: https://issues.apache.org/jira/browse/KAFKA-16843
> Project: Kafka
> Issue Type: Improvement
> Reporter: Chia-Ping Tsai
> Assignee: PoAn Yang
> Priority: Minor
>
> origin discussion:
> [https://github.com/apache/kafka/pull/16072#pullrequestreview-2077368462]
> The method `createPutCacheCallback` has a input argument `preAppendErrors`
> [0]. It is used to keep the "error" happens before appending. However, the
> pre-append error is handled before by calling `responseCallback` [1]. Hence,
> we can remove `preAppendErrors`.
>
> [0]
> https://github.com/apache/kafka/blob/trunk/core/src/main/scala/kafka/coordinator/group/GroupMetadataManager.scala#L387
> [1]
> https://github.com/apache/kafka/blob/4f55786a8a86fe228a0b10a2f28529f5128e5d6f/core/src/main/scala/kafka/coordinator/group/GroupCoordinator.scala#L927C15-L927C84
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
