OmniaGM commented on code in PR #15999:
URL: https://github.com/apache/kafka/pull/15999#discussion_r1626313015
##########
connect/mirror/src/main/java/org/apache/kafka/connect/mirror/MirrorCheckpointConfig.java:
##########
@@ -252,7 +252,13 @@ private static ConfigDef defineCheckpointConfig(ConfigDef
baseConfig) {
ConfigDef.Type.CLASS,
TOPIC_FILTER_CLASS_DEFAULT,
ConfigDef.Importance.LOW,
- TOPIC_FILTER_CLASS_DOC);
+ TOPIC_FILTER_CLASS_DOC)
+ .define(
Review Comment:
How would move the validation to `MirrorMakerConfig` make different? Am
actually re-thinking about this validation now and I am leaning a bit toward
removing it as it might be okay to not validate `MirrorCheckpointConnector` and
treat it in same way as if we are deploying a client before creating the topic.
The connector will just do nothing. The only benefit from such validation would
be letting users aware that this connector isn't doing anything WDYT?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
