showuon commented on code in PR #14778:
URL: https://github.com/apache/kafka/pull/14778#discussion_r1625827494
##########
clients/src/main/java/org/apache/kafka/clients/consumer/ConsumerConfig.java:
##########
@@ -198,7 +198,7 @@ public class ConsumerConfig extends AbstractConfig {
* <code>fetch.max.wait.ms</code>
*/
public static final String FETCH_MAX_WAIT_MS_CONFIG = "fetch.max.wait.ms";
- private static final String FETCH_MAX_WAIT_MS_DOC = "The maximum amount of
time the server will block before answering the fetch request if there isn't
sufficient data to immediately satisfy the requirement given by
fetch.min.bytes.";
+ private static final String FETCH_MAX_WAIT_MS_DOC = "The maximum amount of
time the server will block before answering the fetch request when it is
reading near to the tail of the partition (high-watermark) and there isn't
sufficient data to immediately satisfy the requirement given by
fetch.min.bytes.";
Review Comment:
Should we mention this config is only used for local log fetch?
Also, we should mention this in the end:
`To tune the remote fetch maximum time wait, please refer to
"remote.fetch.max.wait.ms" config.`. WDYT?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
