chia7712 commented on code in PR #16176:
URL: https://github.com/apache/kafka/pull/16176#discussion_r1625383681
##########
build.gradle:
##########
@@ -47,9 +47,11 @@ plugins {
// Updating the shadow plugin version to 8.1.1 causes issue with signing and
publishing the shadowed
// artifacts - see https://github.com/johnrengelman/shadow/issues/901
id 'com.github.johnrengelman.shadow' version '8.1.0' apply false
- // the minimum required JRE of 6.14.0+ is 11
+ // the spotless before 6.14.0 support JDK8, after 6.23.3 support JDK21
Review Comment:
```
Spotless 6.13.0 has issue with Java 21 (see
https://github.com/diffplug/spotless/pull/1920), and Spotless 6.14.0+ requires
JRE 11
We are going to drop JDK8 support. Hence, the spotless is upgrade to newest
version and be applied only if the build env is compatible with JDK 11.
```
WDYT?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
