dajac commented on code in PR #16174:
URL: https://github.com/apache/kafka/pull/16174#discussion_r1624718677
##########
group-coordinator/src/main/java/org/apache/kafka/coordinator/group/consumer/TargetAssignmentBuilder.java:
##########
@@ -64,11 +64,11 @@ public static class TargetAssignmentResult {
/**
* The new target assignment for the group.
*/
- private final Map<String, Assignment> targetAssignment;
+ private final Map<String, MemberAssignment> targetAssignment;
TargetAssignmentResult(
List<CoordinatorRecord> records,
- Map<String, Assignment> targetAssignment
+ Map<String, MemberAssignment> targetAssignment
Review Comment:
Yeah, that's right. I should not have said immutable. What I meant is that
once a `MemberAssignment` is returned by the assignor, it should not change
anymore. Adding a setter to it would loosen the contract in my opinion.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
