clolov commented on code in PR #15673:
URL: https://github.com/apache/kafka/pull/15673#discussion_r1624631817
##########
server-common/src/main/java/org/apache/kafka/server/common/MetadataVersion.java:
##########
@@ -228,7 +231,7 @@ public enum MetadataVersion {
* <strong>Think carefully before you update this value. ONCE A METADATA
VERSION IS PRODUCTION,
* IT CANNOT BE CHANGED.</strong>
*/
- public static final MetadataVersion LATEST_PRODUCTION = IBP_3_7_IV4;
+ public static final MetadataVersion LATEST_PRODUCTION = IBP_3_8_IV1;
Review Comment:
Okay, I believe I have moved ELR to at least IBP_4_0_IV0, but I would prefer
to leave the rest of the test changes for when ELR is launched i.e. I have only
changed the tests to reflect the changes needed for 3.8.1
##########
core/src/test/scala/unit/kafka/server/ListOffsetsRequestTest.scala:
##########
@@ -55,7 +55,7 @@ class ListOffsetsRequestTest extends BaseRequestTest {
.build()
val debugReplicaRequest = ListOffsetsRequest.Builder
- .forReplica(ApiKeys.LIST_OFFSETS.latestVersion,
ListOffsetsRequest.DEBUGGING_REPLICA_ID)
+ .forReplica(ApiKeys.LIST_OFFSETS.latestVersion(),
ListOffsetsRequest.DEBUGGING_REPLICA_ID)
Review Comment:
Corrected
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
