kamalcph commented on PR #16153: URL: https://github.com/apache/kafka/pull/16153#issuecomment-2144721460
> > isRemoteLogStorageSystemEnabled is a getter which makes the code clear to read. > > Pardon me, do you mean `RemoteLogManagerConfig#enableRemoteStorageSystem()` should be renamed to `RemoteLogManagerConfig#isRemoteLogStorageSystemEnabled` Either we should rename `RemoteLogManagerConfig#enableRemoteStorageSystem()` to `RemoteLogManagerConfig#isRemoteStorageSystemEnabled()`. If the rename requires a KIP, then we can continue to use the `KafkaConfig#isRemoteLogStorageSystemEnabled` in all the other places to unify the usage. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
