chia7712 commented on code in PR #16156:
URL: https://github.com/apache/kafka/pull/16156#discussion_r1623465952
##########
clients/src/test/java/org/apache/kafka/clients/consumer/internals/NetworkClientDelegateTest.java:
##########
@@ -140,6 +141,35 @@ public void testEnsureTimerSetOnAdd() {
assertEquals(REQUEST_TIMEOUT_MS,
ncd.unsentRequests().poll().timer().timeoutMs());
}
+ @Test
+ public void testHasAnyPendingRequests() throws Exception {
+ try (NetworkClientDelegate networkClientDelegate =
newNetworkClientDelegate()) {
+ NetworkClientDelegate.UnsentRequest unsentRequest =
newUnsentFindCoordinatorRequest();
+ networkClientDelegate.add(unsentRequest);
+
+ // unsent
+ assertTrue(networkClientDelegate.hasAnyPendingRequests());
+ assertFalse(networkClientDelegate.unsentRequests().isEmpty());
+ assertFalse(client.hasInFlightRequests());
+
+ networkClientDelegate.poll(0, time.milliseconds());
+
+ // in-flight
+ assertTrue(networkClientDelegate.hasAnyPendingRequests());
+ assertTrue(networkClientDelegate.unsentRequests().isEmpty());
+ assertTrue(client.hasInFlightRequests());
+ time.sleep(REQUEST_TIMEOUT_MS);
Review Comment:
Could we mock response instead of making timeout? For example:
```java
// in-flight
assertTrue(networkClientDelegate.hasAnyPendingRequests());
assertTrue(networkClientDelegate.unsentRequests().isEmpty());
assertTrue(client.hasInFlightRequests());
// complete request
client.respond(FindCoordinatorResponse.prepareResponse(Errors.NONE, GROUP_ID,
mockNode()));
networkClientDelegate.poll(0, time.milliseconds());
assertFalse(networkClientDelegate.hasAnyPendingRequests());
assertTrue(networkClientDelegate.unsentRequests().isEmpty());
assertFalse(client.hasInFlightRequests());
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
