philipnee commented on code in PR #16115:
URL: https://github.com/apache/kafka/pull/16115#discussion_r1623382281
##########
clients/src/test/java/org/apache/kafka/clients/consumer/internals/CommitRequestManagerTest.java:
##########
@@ -123,6 +126,47 @@ public void setup() {
this.props.put(VALUE_DESERIALIZER_CLASS_CONFIG,
StringDeserializer.class);
}
+ @Test
+ public void testOffsetFetchRequestStateToStringBase() {
+ final long retryBackoffMs = 10;
+ final long retryBackoffMaxMs = 100;
+ final long expirationTimeMs = 1000;
+ ConsumerConfig config = mock(ConsumerConfig.class);
+ CommitRequestManager.MemberInfo memberInfo = new
CommitRequestManager.MemberInfo();
+
+ this.commitRequestManager = new CommitRequestManager(
+ time,
+ logContext,
+ subscriptionState,
+ config,
+ coordinatorRequestManager,
+ offsetCommitCallbackInvoker,
+ "groupId",
+ Optional.of("groupInstanceId"),
+ metrics);
+
+ this.offsetFetchRequestState = commitRequestManager.new
OffsetFetchRequestState(
+ mock(Set.class),
+ retryBackoffMs, retryBackoffMaxMs, expirationTimeMs,
+ memberInfo
+ );
+
+ this.requestState = new RequestState(
+ logContext,
+ "CommitRequestManager",
+ retryBackoffMs,
+ retryBackoffMaxMs);
+
+ String target = requestState.toStringBase() +
+ ", memberInfo={" + offsetFetchRequestState.memberInfo +
+ "}, expirationTimeMs=" +
(offsetFetchRequestState.expirationTimeMs().isPresent() ?
offsetFetchRequestState.expirationTimeMs() : "undefined") +
Review Comment:
i think we are expecting an expirationTimeMs so just use `expirationTimeMs="
+ expirationTimeMs`
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
