chiacyu commented on code in PR #15863:
URL: https://github.com/apache/kafka/pull/15863#discussion_r1623229305
##########
core/src/main/scala/kafka/log/LogCleaner.scala:
##########
@@ -223,8 +230,8 @@ class LogCleaner(initialConfig: CleanerConfig,
info(s"Updating logCleanerIoMaxBytesPerSecond: $maxIoBytesPerSecond")
throttler.updateDesiredRatePerSec(maxIoBytesPerSecond)
}
-
- shutdown()
+// call shutdownCleaners() instead of shutdown to avoid unnecessary
deletion of metrics
Review Comment:
Thanks for the comments, applied, please take a look.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
