chia7712 commented on code in PR #16013:
URL: https://github.com/apache/kafka/pull/16013#discussion_r1623212627
##########
metadata/src/test/java/org/apache/kafka/controller/QuorumControllerIntegrationTestUtils.java:
##########
@@ -139,15 +140,19 @@ static void sendBrokerHeartbeatToUnfenceBrokers(
if (brokers.isEmpty()) {
return;
}
+ List<CompletableFuture<BrokerHeartbeatReply>> replies = new
ArrayList<>();
for (Integer brokerId : brokers) {
- BrokerHeartbeatReply reply =
controller.processBrokerHeartbeat(ANONYMOUS_CONTEXT,
+ CompletableFuture<BrokerHeartbeatReply> reply =
controller.processBrokerHeartbeat(ANONYMOUS_CONTEXT,
new BrokerHeartbeatRequestData()
.setWantFence(false)
.setBrokerEpoch(brokerEpochs.get(brokerId))
.setBrokerId(brokerId)
.setCurrentMetadataOffset(100000)
- ).get();
- assertEquals(new BrokerHeartbeatReply(true, false, false, false),
reply);
+ );
+ replies.add(reply);
+ }
+ for (CompletableFuture<BrokerHeartbeatReply> reply : replies) {
Review Comment:
how about:
```java
replies.forEach(reply -> assertEquals(new BrokerHeartbeatReply(true, false,
false, false), reply.join()));
```
##########
metadata/src/test/java/org/apache/kafka/controller/QuorumControllerIntegrationTestUtils.java:
##########
@@ -139,15 +140,19 @@ static void sendBrokerHeartbeatToUnfenceBrokers(
if (brokers.isEmpty()) {
return;
}
+ List<CompletableFuture<BrokerHeartbeatReply>> replies = new
ArrayList<>();
for (Integer brokerId : brokers) {
Review Comment:
We can rewrite it by lambda:
```java
List<CompletableFuture<BrokerHeartbeatReply>> replies =
brokers.stream().map(brokerId ->
controller.processBrokerHeartbeat(ANONYMOUS_CONTEXT,
new BrokerHeartbeatRequestData()
.setWantFence(false)
.setBrokerEpoch(brokerEpochs.get(brokerId))
.setBrokerId(brokerId)
.setCurrentMetadataOffset(100000)
)).collect(Collectors.toList());
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
